Add response token count logic to Gemini instrumentation. #1486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅MegaLinter analysis: Success
See detailed reports in MegaLinter artifacts
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## feature-llm-token-counts #1486 +/- ##
============================================================
+ Coverage 81.48% 81.59% +0.11%
============================================================
Files 209 207 -2
Lines 23815 23933 +118
Branches 3753 3793 +40
============================================================
+ Hits 19406 19529 +123
+ Misses 3153 3127 -26
- Partials 1256 1277 +21 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
TimPansino
approved these changes
Sep 24, 2025
…python-agent into gemini-token-counting
…python-agent into gemini-token-counting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates Gemini instrumentation and tests to pull token counts directly from the response object. If a customer has an LLM token counting callback function registered, this will still take priority over the response token count values.
It also removes token count calculations from error cases as the agent will consistently stop reporting token counts when a error was met during the creation of a text generation.